Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort_as not working with contributor ids in page YAML #854

Open
1 task done
Erin-Cecele opened this issue Oct 6, 2023 · 2 comments
Open
1 task done

sort_as not working with contributor ids in page YAML #854

Erin-Cecele opened this issue Oct 6, 2023 · 2 comments
Assignees
Labels
bug Actual behavior does not match expected behavior quire-11ty This is an issue with the quire-11ty package status:backlog Issue is a lower priority but needs to eventually be addressed

Comments

@Erin-Cecele
Copy link
Collaborator

Before proceeding, make sure there isn’t an existing issue for this bug.

  • I have searched the existing issues and determined this is a new bug.

Expected Behavior

When you add sort_as under contributor ids in the page YAML it should sort them according to the desired order.

Actual Behavior

Adding sort_as under contributor ids in the page YAML has no effect on the ordering.

Steps to Reproduce

  1. Start a new Quire project
  2. Add contributors to the publication.yaml
  3. List contributor ids in the essay.md page YAML
  4. Add sort_as to the contributors to override the alphabetical ordering and check to see if it changed the ordering

Version Numbers

[Project]
quire-cli 1.0.0-rc.10
quire-11ty 1.0.0-rc.14
starter /Users/edunigan/GitHub/[email protected]
[System]
quire-cli 1.0.0-rc.10
node v18.16.0
npm 9.5.1
os Darwin 21.6.0

Web Browser

Chrome Version 117.0.5938.88 (Official Build) (x86_64)

Relevant Terminal/Shell Output

N/A

Supporting Information

Screen Shot 2023-10-06 at 2 23 12 PM
@Erin-Cecele Erin-Cecele added the status:triage needed Issue needs to be triaged by the Quire team. This label is automatically applied to new issues. label Oct 6, 2023
@Erin-Cecele Erin-Cecele self-assigned this Oct 6, 2023
@Erin-Cecele
Copy link
Collaborator Author

This came up with Inventories and Surveys: thegetty/inventories-and-surveys#13 and Bronze Guidelines: https://github.com/thegetty/bronze-guidelines/issues/64

@Erin-Cecele Erin-Cecele added quire-11ty This is an issue with the quire-11ty package bug Actual behavior does not match expected behavior labels Oct 11, 2023
@Erin-Cecele Erin-Cecele added status:backlog Issue is a lower priority but needs to eventually be addressed and removed status:triage needed Issue needs to be triaged by the Quire team. This label is automatically applied to new issues. labels Dec 6, 2023
@geealbers
Copy link
Member

The fix I found that worked in the Bronze Guidelines book was a single line adding the sort_as value in the getContributor filter:

  // Add local sort_as value if one is provided
  item.sort_as ? contributor.sort_as = item.sort_as : ''

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Actual behavior does not match expected behavior quire-11ty This is an issue with the quire-11ty package status:backlog Issue is a lower priority but needs to eventually be addressed
Projects
None yet
Development

No branches or pull requests

2 participants