Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{% contributors context=pageContributors format='bio' %} lists all publication essays, not just for pageContributors #847

Open
1 task done
Erin-Cecele opened this issue Sep 14, 2023 · 2 comments
Assignees
Labels
bug Actual behavior does not match expected behavior quire-11ty This is an issue with the quire-11ty package status:backlog Issue is a lower priority but needs to eventually be addressed

Comments

@Erin-Cecele
Copy link
Collaborator

Erin-Cecele commented Sep 14, 2023

Before proceeding, make sure there isn’t an existing issue for this bug.

  • I have searched the existing issues and determined this is a new bug.

Expected Behavior

{% contributors context=pageContributors format='bio' %} should list all the contributors included in Page YAML, their individual bios, and their other essay contributions within the publication unless that contribution is the page the shortcode is being used on.

Actual Behavior

{% contributors context=pageContributors format='bio' %} lists the contributors included in that page's page YAML, their bios, and, erroneously, all the other essays by page YAML contributors throughout the publication as well as the essay the shortcode appears on.

Screen Shot 2023-09-14 at 1 20 30 PM

In the example above, Mahdi Sahragard only contributed the first essay. None of the other items in that list should be appearing.

Steps to Reproduce

  1. Add contributor info to the Page YAML of an essay
contributor: 
  - first_name: Anneka  
    last_name: Lenssen
    bio: 
  1. Add the shortcode {% contributors context=pageContributors format='bio' %}

Version Numbers

[grj-19]
quire-cli 1.0.0-rc.10
quire-11ty 1.0.0-rc.14
starter /Users/galbers/GitHub/[email protected]
[System]
quire-cli 1.0.0-rc.10
node v18.16.0
npm 9.5.1
os Darwin 21.6.0

Web Browser

Chrome: Version 117.0.5938.62 (Official Build) (x86_64)

Relevant Terminal/Shell Output

No response

Supporting Information

I found that adding *** above the shortcode removed the list of essays:

***
{% contributors context=pageContributors format='bio' %} 
@Erin-Cecele Erin-Cecele added the status:triage needed Issue needs to be triaged by the Quire team. This label is automatically applied to new issues. label Sep 14, 2023
@Erin-Cecele Erin-Cecele self-assigned this Sep 14, 2023
@Erin-Cecele
Copy link
Collaborator Author

Erin-Cecele commented Oct 6, 2023

This is similar to issue #853 - an issue inspired by an error in Inventories and Surveys: thegetty/inventories-and-surveys#9. In this issue, the error was caused by context=publicationContributors.

@Erin-Cecele Erin-Cecele added bug Actual behavior does not match expected behavior quire-11ty This is an issue with the quire-11ty package labels Oct 11, 2023
@Erin-Cecele Erin-Cecele added status:backlog Issue is a lower priority but needs to eventually be addressed and removed status:triage needed Issue needs to be triaged by the Quire team. This label is automatically applied to new issues. labels Dec 6, 2023
@Erin-Cecele
Copy link
Collaborator Author

Erin-Cecele commented Dec 15, 2023

When I refer to "contributors included in that page's page YAML" I am referring to the contributors added with:

contributors
  - first_name: 
    last_name: 

This is separate from contributors listed in the publication.yaml and added via an id in the page YAML, which this issue does not appear to affect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Actual behavior does not match expected behavior quire-11ty This is an issue with the quire-11ty package status:backlog Issue is a lower priority but needs to eventually be addressed
Projects
None yet
Development

No branches or pull requests

1 participant