Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit/get involved #676

Merged
merged 3 commits into from
Aug 3, 2023
Merged

Edit/get involved #676

merged 3 commits into from
Aug 3, 2023

Conversation

Erin-Cecele
Copy link
Collaborator

Thank you for contributing to the Quire Documentation & Website! Please complete the form below to submit your pull request for review.

For the Title of this pull request, please use the format "Type/Issue-#: Brief description." For Type, the options are Edit, Add, Translate. Issue-# is only needed if this pull request addresses an existing issue.

Checklist

Please put an X within the brackets that apply [X].

  • I have read the CONTRIBUTING.md file.

  • I have made my changes in a new branch and not directly in the main branch

  • I am requesting feedback on a draft pull request

Is this pull request related to an open issue? If so, what is the issue number?

No

Please describe the goal of this pull request and the changes that were made.

Update the website with new bug-reporting instructions.

Additional Comments

@geealbers, what do you think of the line I added at the end of each page pointing people to the bug-reporting instructions? Is it helpful? Is there a better way to do it?

@geealbers
Copy link
Member

I like the idea of the line on the bottom of each page. Can you provide a screenshot of how it looks now? I'm wondering if it should be visually set off in some way. Perhaps by putting it in a different color text, a different size text or font, or adding a rule line or just some extra margin above. You could toy with some custom.css if you agree.

Also, I think this should be added in through one of the page templates rather than having it copied individually in every markdown file. Do you want to poke around and see if you can figure out a way to do that? (Or I can later.)

@Erin-Cecele
Copy link
Collaborator Author

Here's the screenshot. I completely agree about having them visually set off.

Screen Shot 2023-06-30 at 2 38 10 PM

And I agree that having it added to the website template is more efficient.

I'll see what I can figure out for both the CSS and the template.

@Erin-Cecele
Copy link
Collaborator Author

@geealbers I removed the bug reporting note from this PR, and instead it's just edits to the Get Involved page. OK to merge?

@Erin-Cecele
Copy link
Collaborator Author

Oops also wanted to mention I created an issue for us to address the bug reporting note: #688

Copy link
Member

@geealbers geealbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good to merge

@Erin-Cecele Erin-Cecele merged commit cc4754a into main Aug 3, 2023
@Erin-Cecele Erin-Cecele deleted the edit/get-involved branch August 3, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants