Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize deployment script should handle updates to itself #438

Open
emilgoldsmith opened this issue Aug 3, 2018 · 0 comments
Open

Finalize deployment script should handle updates to itself #438

emilgoldsmith opened this issue Aug 3, 2018 · 0 comments

Comments

@emilgoldsmith
Copy link
Member

Expected Behavior

Updating the finalize-deployment.sh script should actually run the newest one

Current Behavior

Right now it runs the old one, because it calls git pull inside it so it won't be updated at the time of calling

Possible Solution

The more hardcore fix is something like detecting if it changed and then rerunning the script inside the script. But I think the easiest way is probably just to do a ssh USER@IP bash -ic 'cd ~/server && git pull before running the script in our CI config, and maybe also do some checking to make sure that the pull was clean (no conflicts etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant