From 4212552b2882eff0d9a54629c7e93650effda388 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20N=C3=A9grier?= Date: Sat, 1 Aug 2020 23:03:11 +0200 Subject: [PATCH 1/4] Fixing bug in quoted columns (on Oracle) --- src/SchemaAnalyzer.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/SchemaAnalyzer.php b/src/SchemaAnalyzer.php index 3cf357f..52a5778 100644 --- a/src/SchemaAnalyzer.php +++ b/src/SchemaAnalyzer.php @@ -139,7 +139,7 @@ public function isJunctionTable(Table $table, $ignoreReferencedTables = false) } if ($table->hasPrimaryKey()) { - $pkColumns = $table->getPrimaryKeyColumns(); + $pkColumns = $table->getPrimaryKey()->getUnquotedColumns(); } else { $pkColumns = []; } @@ -513,8 +513,8 @@ private function isInheritanceRelationship(ForeignKeyConstraint $fk) if (!$fk->getLocalTable()->hasPrimaryKey()) { return false; } - $fkColumnNames = $fk->getLocalColumns(); - $pkColumnNames = $fk->getLocalTable()->getPrimaryKeyColumns(); + $fkColumnNames = $fk->getUnquotedLocalColumns(); + $pkColumnNames = $fk->getLocalTable()->getPrimaryKey()->getUnquotedColumns(); sort($fkColumnNames); sort($pkColumnNames); From db30844e365b00bb1f943f8cf5cfb4305d99ef6f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20N=C3=A9grier?= Date: Sat, 1 Aug 2020 23:10:32 +0200 Subject: [PATCH 2/4] Fixing dependency --- composer.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/composer.json b/composer.json index 080916c..f24e1ae 100644 --- a/composer.json +++ b/composer.json @@ -21,6 +21,6 @@ }, "require-dev": { "phpunit/phpunit": "~4.0", - "satooshi/php-coveralls": "dev-master" + "satooshi/php-coveralls": "^1.0" } } From 5074cd9f59160b541fa6c21f9a5804939664a7d7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20N=C3=A9grier?= Date: Sat, 1 Aug 2020 23:15:23 +0200 Subject: [PATCH 3/4] Fixing min depth + changing tested PHP versions --- .travis.yml | 2 +- composer.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index 734a378..e2d63bf 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,9 +1,9 @@ language: php php: - - 5.5 - 5.6 - 7.0 + - 7.4 env: matrix: diff --git a/composer.json b/composer.json index f24e1ae..6deeced 100644 --- a/composer.json +++ b/composer.json @@ -15,7 +15,7 @@ }, "require": { "clue/graph": "~0.9.0", - "doctrine/dbal": "~2.4", + "doctrine/dbal": "~2.5", "doctrine/cache": "^1.4.1", "graphp/algorithms": "~0.8.0" }, From d0ba8ef7ef5f8cfdf6ddc14499b3e901c7840ee0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20N=C3=A9grier?= Date: Sat, 1 Aug 2020 23:22:20 +0200 Subject: [PATCH 4/4] Fixing minimum phpunit version --- composer.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/composer.json b/composer.json index 6deeced..6f83c7a 100644 --- a/composer.json +++ b/composer.json @@ -20,7 +20,7 @@ "graphp/algorithms": "~0.8.0" }, "require-dev": { - "phpunit/phpunit": "~4.0", + "phpunit/phpunit": "^4.8.36", "satooshi/php-coveralls": "^1.0" } }