Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename 'pk' field to '_pk' #80

Open
jayvdb opened this issue Nov 10, 2018 · 1 comment
Open

Rename 'pk' field to '_pk' #80

jayvdb opened this issue Nov 10, 2018 · 1 comment
Milestone
v0.23.0

Comments

@jayvdb
Copy link
Collaborator

jayvdb commented Nov 10, 2018

To better distinguish between defined fields and internally created fields, 'pk' should be given a prefix _.

As statik grows, other internal fields will become necessary, and we need to avoid clashes with model field names.
@jayvdb
Copy link
Collaborator Author

jayvdb commented Nov 10, 2018

Note the existing pk needs to remain supported for backwards compatibility

kiy4h added a commit to kiy4h/statik that referenced this issue Nov 12, 2018
@kiy4h
Rename 'pk' field to '_pk'
62ed298 
Closes thanethomson#80
@kiy4h kiy4h mentioned this issue Nov 12, 2018
Closed
kiy4h added a commit to kiy4h/statik that referenced this issue Nov 12, 2018
@kiy4h
Rename 'pk' field to '_pk'
129de54 
Closes thanethomson#80
kiy4h added a commit to kiy4h/statik that referenced this issue Nov 13, 2018
@kiy4h
Rename 'pk' field to '_pk'
4ef7415 
Closes thanethomson#80
@thanethomson thanethomson added this to the v0.23.0 milestone Jan 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.23.0
Development

No branches or pull requests
2 participants
@jayvdb @thanethomson