Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize redis_reliablequeue connect/disconnect output #150

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

ZeWaka
Copy link
Contributor

@ZeWaka ZeWaka commented Sep 25, 2023

Essentially makes it match the

{
  "success": bool
  "content": string
}

format instead of just returning the raw rust error through ? propagation.

@ZeWaka
Copy link
Contributor Author

ZeWaka commented Sep 25, 2023

should probably test this

@ZeWaka ZeWaka marked this pull request as draft September 25, 2023 05:56
@AffectedArc07
Copy link
Member

AffectedArc07 commented Sep 25, 2023

should probably test this

I can TM this on para, I know we use redis pubsub.

This isnt pubsub nevermind

@ZeWaka
Copy link
Contributor Author

ZeWaka commented Feb 20, 2024

i intend to get to this sometime now, since goon uses this in prod

@ZeWaka
Copy link
Contributor Author

ZeWaka commented Apr 15, 2024

x

@ZeWaka ZeWaka marked this pull request as ready for review April 16, 2024 03:19
@ZeWaka ZeWaka merged commit 0076041 into master Apr 17, 2024
2 checks passed
@ZeWaka ZeWaka deleted the redis-standardize-output branch April 17, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants