Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"|" is not a keywords #37

Open
Tracked by #1
jianboy opened this issue Aug 19, 2021 · 3 comments
Open
Tracked by #1

"|" is not a keywords #37

jianboy opened this issue Aug 19, 2021 · 3 comments

Comments

@jianboy
Copy link

jianboy commented Aug 19, 2021

"|" is not a keywords.

image

microsoft/vscode#130229 (comment)

@geekley
Copy link

geekley commented Jun 17, 2022

They would make much more sense as something like:
punctuation.definition.string.block-scalar.literal.yaml
punctuation.definition.string.modifier.chomping-indicator.yaml
punctuation.definition.string.modifier.indentation-indicator.yaml

@jianboy
Copy link
Author

jianboy commented Jun 18, 2022

keyword is a word such as:

"function", "class", "def" and so on. To make the font more prominent, I made the following settings:

		"keywords": {
			"fontStyle": "italic"
		},

I don't think "|" is a keyword. it may lead to mistakes

@geekley
Copy link

geekley commented Jun 18, 2022

To be fair, there are "operator keywords" (e.g. +=), but those should be under keyword.operator.
keyword.control should be used for control instructions like if for return try etc.

That | is very similar to the " ' string initiators IMO, though it's arguable since it does allow a line comment after it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants