Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yaml grammar does not recognize all quotes #30

Open
Tracked by #1
alexr00 opened this issue Jan 7, 2019 · 8 comments
Open
Tracked by #1

yaml grammar does not recognize all quotes #30

alexr00 opened this issue Jan 7, 2019 · 8 comments

Comments

@alexr00
Copy link

alexr00 commented Jan 7, 2019

From @Noiknez on November 18, 2018 10:59

A false missing double quote in yaml files cause the rest of the file to be recognized incorrectly. The opening double quote is not being recognized.

See the comment here: #30 (comment)

and here: #30 (comment)

Copied from original issue: microsoft/vscode#63382

@alexr00
Copy link
Author

alexr00 commented Jan 7, 2019

From @roblourens on November 18, 2018 17:39

Can you share that file?

@alexr00
Copy link
Author

alexr00 commented Jan 7, 2019

From @Noiknez on November 18, 2018 17:43

Tesseract_Guilde.zip

@alexr00
Copy link
Author

alexr00 commented Jan 7, 2019

From @dpoetzschke on November 22, 2018 14:52

I ran into the same error when configuring .circleci/config.yaml

The problem seems to be a missing closing quote, which in my case in not true but falsely recognized as such.
When checking Noiknez file i get the same issue that can also be fixed by adding a false double-quote.

A smaller version of my file is this, which can be fixed by adding a second double-quote in line 27


jobs:
  dockerize:
    working_directory: ~/project

    docker:
      - image: google/cloud-sdk

    steps:
        - checkout

        - run:
        name: 'Build and push docker image'
        command: |
          docker run \
                --rm \
                -w /app \
                -v $(pwd):/app \
                -v ${HOME}:/config \
                -v /var/run/docker.sock:/var/run/docker.sock \
                google/cloud-sdk \
                sh -c "\
                  command1 && \
                  command2 && \
                  command3
                "
        - run:
        name: 'test'
        command: |
          ....
          ....```

@alexr00
Copy link
Author

alexr00 commented Jan 7, 2019

From @Noiknez on November 24, 2018 17:44

I have more information, but I don't know if it is related

image

image

image

@alexr00
Copy link
Author

alexr00 commented Jan 7, 2019

It looks like the grammar doesn't correctly account for double quotes. From @dpoetzschke example above:
image
It seems like that shouldn't be recognized as unquoted text.

@alexr00 alexr00 changed the title yaml file does not colorise yaml grammar does not recognize all quotes Jan 7, 2019
@dpoetzschke
Copy link

@alexr00 i am not sure if this is a bundle issue.
When i use TextMate with the YAML bundle or Sublime with the bundle everything works as expected.
This looks to me as if VSCode does not work correctly with the bundle?!

@alexr00
Copy link
Author

alexr00 commented Feb 27, 2019

@dpoetzschke can you point me to some instructions for loading the bundle into Sublime? I have tried the steps here: https://stackoverflow.com/questions/7666977/syntax-highlighting-for-jade-in-sublime-text-2, but I can't get the new grammar to show up in the syntax highlighting list.

@dpoetzschke
Copy link

@alexr00
i got my new MBP last month and i no longer have a configured sublime2/3 at hand as i only need VSC.
I was not able to load the bundle into the newest version of Sublime 2 as the newest format is not supported. Also Sublime 3 uses a new format for syntax that i haven't used yet.
The default YAML bundles delivered with Sublime 2 / 3 are working with the given code example as is TextMate with the newest YAML bundle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants