Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"false positive" on return type-hint object with name starting with a scalar type #85

Open
VaN-dev opened this issue May 16, 2019 · 0 comments

Comments

@VaN-dev
Copy link

VaN-dev commented May 16, 2019

hello,

I found this bug when doing a code review on github. github support told me to look at this repository, which is what they use for php syntax highlighting.

A picture is worth 1000 words:
image

the regex for scalar types detection (int, string, etc.) seems broken. See how the "Int" part of my "InternalUser" type-hint turned to red, because regex detected it as "int". It should probably be fixed by making sure there is no additional characters behind the pattern (and by making a case-sensitive detection).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant