Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect highlighting with PHP 7.3 heredoc strings #84

Open
Riimu opened this issue Apr 26, 2019 · 1 comment · May be fixed by #88
Open

Incorrect highlighting with PHP 7.3 heredoc strings #84

Riimu opened this issue Apr 26, 2019 · 1 comment · May be fixed by #88

Comments

@Riimu
Copy link

Riimu commented Apr 26, 2019

In PHP 7.3, heredoc (and nowdoc) strings can be terminated by the keyword at arbitrary indentation (which is used to strip indentation from previous lines).

For example, the following PHP code works in PHP7.3:

$string = <<<DELIMITER
  Foobar
  DELIMITER;
  
var_dump($string);

and outputs:

string(6) "Foobar"

However, as you can see, the highlighting grammar does not recognize the indented heredoc termination and it parses the var_dump as part of the heredoc string.

@d-luk
Copy link

d-luk commented Jan 2, 2020

Same problem here. A fix would be appreciated!

miken32 added a commit to miken32/php.tmbundle that referenced this issue Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants
@Riimu @d-luk and others