Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submodule peering example #225

Open
philipwigg opened this issue Jan 3, 2021 · 4 comments
Open

Submodule peering example #225

philipwigg opened this issue Jan 3, 2021 · 4 comments
Labels
good first issue Good for newcomers P4 low priority issues triaged Scoped and ready for work

Comments

@philipwigg
Copy link

This Simple VPC Network Peering example claims that This example creates a VPC Network peering between two VPCs..

To me, it seems to create three VPCs and create a A->B and A->C type peering setup.

Which should it be?

@bharathkkb
Copy link
Member

Hi @philipwigg
It creates local-network <--> peer-network-1 and local-network <--> peer-network-2. For any two VPCs, A and B, the module network-peering creates A<-->B

@philipwigg
Copy link
Author

Thanks for your response. My point is, the example does not in fact create "a VPC peering between two VPCs" but rather it's 2 VPC peerings and three VPCs as you've referenced in your reply.

@bharathkkb
Copy link
Member

@philipwigg yes happy to review PR to flesh out the docs. Also technically its 4 VPC peerings, each instance of the module creates 2 peerings A-to-B and B-to-A.

@bharathkkb bharathkkb added good first issue Good for newcomers P4 low priority issues labels Jan 5, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2021

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Mar 6, 2021
@morgante morgante added triaged Scoped and ready for work and removed Stale labels Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P4 low priority issues triaged Scoped and ready for work
Projects
None yet
Development

No branches or pull requests

3 participants