Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bucket not found: registry #58

Open
compalmanel opened this issue Oct 2, 2020 · 6 comments
Open

Bucket not found: registry #58

compalmanel opened this issue Oct 2, 2020 · 6 comments
Labels
bug Something isn't working good first issue Good for newcomers P2 high priority issues triaged Scoped and ready for work

Comments

@compalmanel
Copy link

compalmanel commented Oct 2, 2020

I've deployed GitLab using the terraform-google-gke-gitlab module. Everything looks great, the container registry has been used without any issues.

However we've noticed that the backup-utility emits this warning:

Bucket not found: registry. Skipping backup of registry ...

In values.yaml.tpl the registry is being assigned storage, and that seems to work... However we might also need to expose the bucket to the backup utility?

Just to be clear, the issue is that the bundled backup utility is not being able to access the registry bucket and doesn't include that in the tarball.

Can you please help?

Thank you

@morgante
Copy link
Contributor

morgante commented Oct 5, 2020

Based on this doc it looks like we need to configure global.appConfig.backups.bucket=gitlab-backup-storage and global.appConfig.backups.tmpBucket=gitlab-tmp-storage. The bucket is already created though.

@morgante morgante added bug Something isn't working good first issue Good for newcomers P2 high priority issues triaged Scoped and ready for work labels Oct 5, 2020
@compalmanel
Copy link
Author

Based on this doc it looks like we need to configure global.appConfig.backups.bucket=gitlab-backup-storage and global.appConfig.backups.tmpBucket=gitlab-tmp-storage. The bucket is already created though.

I've also been playing around with that. Adding the link to a tmpBucket is necessary to have a clean restore, I have a patch for that and can submit it if you find it useful.

But this is a different issue.

@compalmanel
Copy link
Author

compalmanel commented Oct 6, 2020

I wonder if the registry bucket also needs to be mentioned in the appConfig section of values.yaml.tpl?

@morgante
Copy link
Contributor

morgante commented Oct 6, 2020

@compalmanel That seems likely. A PR would be welcome.

@compalmanel
Copy link
Author

I've tried adding both:

    registry:
      bucket: ${PROJECT_ID}-registry
      connection:
        secret: gitlab-rails-storage
        key: connection

and

    registry:
      bucket: ${PROJECT_ID}-registry
      connection:
        secret: gitlab-registry-storage
        key: connection

to appConfig, but neither worked. I still get

Bucket not found: registry. Skipping backup of registry ...

when trying to execute backup-utility.

@morgante
Copy link
Contributor

morgante commented Oct 6, 2020

At that point I don't think it's an issue with the Terraform module - it might be worth checking with GitLab about how those values must be provided (possibly the Helm chart isn't correct).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers P2 high priority issues triaged Scoped and ready for work
Projects
None yet
Development

No branches or pull requests

2 participants