Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variable allow_stopping_for_update #111

Open
intotecho opened this issue Jul 28, 2022 · 3 comments
Open

Add variable allow_stopping_for_update #111

intotecho opened this issue Jul 28, 2022 · 3 comments
Labels
backlog enhancement New feature or request good first issue Good for newcomers triaged Scoped and ready for work

Comments

@intotecho
Copy link

TL;DR

So when terraform updates the host, say with a new startup script. terraform apply won't fail with

Error: Changing the machine_type, min_cpu_platform, service_account, enable_display, shielded_instance_config, scheduling.node_affinities or network_interface.[#d].(network/subnetwork/subnetwork_project) or advanced_machine_features on a
started instance requires stopping it. To acknowledge this, please set allow_stopping_for_update = true in your config.
You can also stop it by setting desired_status = "TERMINATED", but the instance will not be restarted after the update.

Terraform Resources

No response

Detailed design

No response

Additional information

No response

@intotecho intotecho added the enhancement New feature or request label Jul 28, 2022
@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Sep 26, 2022
@stevereaver
Copy link
Contributor

This would actually be pretty easy to implement, but what would be the point ? The instance would not start itself back up resulting in you having to go into the project and re-start it yourself anyway. It might be better to use metadata_startup_script for the startup script that way it will destroy the instance and recreate it from scratch leaving you with a running instance. But that would lead to other requirements.....

@g-awmalik
Copy link
Contributor

I think adding a var to set allow_stopping_for_update is reasonable for this use case. Also, we encourage PRs if you're able to create one and I'll be happy to review it for you.

@g-awmalik g-awmalik added triaged Scoped and ready for work good first issue Good for newcomers labels Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog enhancement New feature or request good first issue Good for newcomers triaged Scoped and ready for work
Projects
None yet
Development

No branches or pull requests

3 participants