Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alleviate need to edit manually in 0-bootstrap the file for a particular deployment model #1225

Closed
mromascanu123 opened this issue May 9, 2024 · 5 comments
Assignees
Labels

Comments

@mromascanu123
Copy link

TL;DR

In 0-bootstrap the default deployment model is cloudbuild. If not using cloudbuild need to manually rename and edit files. Instead can use a simple script and a hierarchy of deployment-specific configurations (see example image). A simple script can setup the proper environment for a particular deployment model (see prep.sh.zip)
image
prep.sh.zip

Terraform Resources

N/A

Detailed design

N/A (see script & tree)

Additional information

No response

@mromascanu123 mromascanu123 added the enhancement New feature or request label May 9, 2024
Copy link

github-actions bot commented Jul 8, 2024

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Jul 8, 2024
@mromascanu123
Copy link
Author

This was already addressed and fixed in the fork based on TEF and the fix is quite simple - a prep.sh script
Ideally incorporate the fix in TEF - please talk to the Google team working on the fork (Saurajit Banerjee [email protected], Brett Tackaberry [email protected].)

@eeaton
Copy link
Collaborator

eeaton commented Jul 9, 2024

Thanks for flagging @mromascanu123 , can you point me towards this fix in the fork?

@mromascanu123
Copy link
Author

@daniel-cit daniel-cit self-assigned this Aug 23, 2024
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Oct 22, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants