Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate hardcoding of business_unit (1 & 2) in 4-Projects #1154

Closed
mromascanu123 opened this issue Mar 12, 2024 · 2 comments
Closed

Eliminate hardcoding of business_unit (1 & 2) in 4-Projects #1154

mromascanu123 opened this issue Mar 12, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@mromascanu123
Copy link

TL;DR

  • why hardcoded rather than passed via global config via their parameters
  • why subnet_ip_range hardcoded?

Terraform Resources

No response

Detailed design

Provide configurations via top-level global config or at least tfvar-based at the package level

Additional information

No response

@mromascanu123 mromascanu123 added the enhancement New feature or request label Mar 12, 2024
@fmichaelobrien
Copy link
Contributor

@sleighton2022
Copy link
Collaborator

Closing. Our working principal is that this is example code, and not a module. If something needs to be put in place only once, we won't create a variable. If something is used in multiple places, we will use a variable. May be fixed in #1226

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants