Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update GMK resource examples now that Clusters and Topic resources are GA #759

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jessdejong
Copy link
Contributor

Description

GMK Clusters and Topics are getting promoted to GA after the submission of GoogleCloudPlatform/magic-modules#12264. We need to update our public documentation to use our GA resources instead of the google-beta ones. Issue: https://b.corp.google.com/issues/377724373

Checklist

Readiness

Style

Testing

Intended location

API enablement

  • If the sample needs an API enabled to pass testing, I have added the service to the Test setup file

Review

  • If this sample adds a new directory, I have added codeowners to the CODEOWNERS file

@jessdejong jessdejong requested review from a team as code owners November 6, 2024 19:56
Copy link

conventional-commit-lint-gcf bot commented Nov 6, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@jessdejong jessdejong changed the title Update GMK resource examples now that Clusters and Topic resources are GA docs: Update GMK resource examples now that Clusters and Topic resources are GA Nov 6, 2024
@jessdejong
Copy link
Contributor Author

This may need (but I might not be able to successfully trigger this).

/gcbrun

Copy link

@johndee7310 johndee7310 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Ship it for GA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants