Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

privateca root ca example is invalid for a standard compliant root ca #630

Open
hoexter opened this issue Apr 2, 2024 · 2 comments · May be fixed by #631
Open

privateca root ca example is invalid for a standard compliant root ca #630

hoexter opened this issue Apr 2, 2024 · 2 comments · May be fixed by #631
Assignees

Comments

@hoexter
Copy link

hoexter commented Apr 2, 2024

TL;DR

The sample in privateca/certificate_authority_basic/main.tf looks like it's a copy of the subordinate setup and not for the root.

Expected behavior

Sample should be somewhat compliant to RFC 5280 and CA/B Baseline Requirements.

Observed behavior

SAN on Root -> does not make any sense
pathLen on Root is not forbidden but according to the rfc not evaluated and not recommended by CA/B BR
extendedKeyUsage is forbidden by CA/B BR on a root

Terraform Configuration

does not apply

Terraform Version

does not apply

Additional information

No response

@hoexter hoexter linked a pull request Apr 2, 2024 that will close this issue
4 tasks
@iennae
Copy link
Contributor

iennae commented Apr 16, 2024

Thanks for your feedback @hoexter and the additional reference materials. They are super helpful. While I've left feedback on the PR, it seems like we may need to get the main terraform docs updated as well so that we are matching up our docs across pages. @msampathkumar do you have knowledge on these samples?

@msampathkumar
Copy link
Contributor

msampathkumar commented Sep 10, 2024

This code samples is shown in https://cloud.google.com/certificate-authority-service/docs/creating-certificate-authorities#create-root-ca which focuses on Root CA.

Reaching out to the TW(Alida) for assitance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants