Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error codes #50

Open
panosfol opened this issue Mar 5, 2024 · 1 comment
Open

Error codes #50

panosfol opened this issue Mar 5, 2024 · 1 comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@panosfol
Copy link
Collaborator

panosfol commented Mar 5, 2024

I believe we should add error codes by using #define macro. That way we can have uniformity on our return values of our functions.
Each code should be unique and usable by multiple functions and should replace the existing return values i.e:

return -1;

would become

return EFAIL;

or something more specific.
@charmitro thoughts on what are error code naming convention should be?

@panosfol panosfol added documentation Improvements or additions to documentation good first issue Good for newcomers labels Mar 5, 2024
@charmitro
Copy link
Contributor

Ack and agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants