Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

termux-notification actions don't work #653

Closed
ErrrorMaxx opened this issue Jan 5, 2024 · 9 comments
Closed

termux-notification actions don't work #653

ErrrorMaxx opened this issue Jan 5, 2024 · 9 comments

Comments

@ErrrorMaxx
Copy link

Problem description

Instead of executing termux-notification button's action, wakelock is stopped and no action really executed

Steps to reproduce

termux-wake-lock
termux-notification -i sshd -c '...' --priority max --ongoing --button1 'Stop' --button1-action 'termux-notification-remove sshd'

and press 'Stop' button on notification

Expected behavior

Wakelock is still here and action actually works

Additional information

  • termux-api application version: 0.50.1+b732327
  • termux-api package version (installed through apt): 0.58.0
  • Android OS version: 13
  • Device model: Tecno Camon 20 Pro 5G
@BruceLee027
Copy link

termux-wake-lock
termux-notification -i sshd

@ErrrorMaxx
Copy link
Author

... Notifications itself works (shows). Click actions works. Button actions DO NOT

@termux termux deleted a comment from BruceLee027 Feb 15, 2024
@termux termux deleted a comment from BruceLee027 Feb 15, 2024
@termux termux deleted a comment from twaik Feb 15, 2024
@ErrrorMaxx
Copy link
Author

I think this is actually the same issue as in #677

Because after this line:

termux-notification --action "termux-dialog" -t Suspicious -c NotReally

This line now works:

termux-notification -i sshd -c '...' --priority max --ongoing --button1 'Stop' --button1-action 'termux-notification-remove sshd'

But incurrectly: Button1 works, but runs termux-dialog instead of termux-notification-remove sshd

Closing this issue in favor of #677

@SpaceEngineer17
Copy link

Have you done any research where the problem is?

@ErrrorMaxx
Copy link
Author

No, I'm not. But problem gone after downgrading to latest release

@ErrrorMaxx ErrrorMaxx closed this as not planned Won't fix, can't repro, duplicate, stale Apr 26, 2024
@SpaceEngineer17
Copy link

When downgraded, SAF scripts aren't working.

Source code is same, does that mean build process/gradle scripts/ext. Libs affecting the App or something interesting happening in the code, I wonder.

@ErrrorMaxx
Copy link
Author

ErrrorMaxx commented Apr 27, 2024

I don't understand what do you mean by "source code is same". SAF was implemented literally way later than latest release happened. So latest release is actually really old version

@sylirre
Copy link
Member

sylirre commented Apr 27, 2024

Yeah, these changes are not released. If you want SAF, please use Git build of Termux:API.

See changes since the latest release: v0.50.1...master

Scripts are not standalone. If feature missing in Termux:API app, these scripts won't work.

@SpaceEngineer17
Copy link

Oh, I thought the latest build (v0.50.1) was made with the present source code.

Now I understood they are different.
Thank you.

So the termux-notification actions bug might came from one of these changes , I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants