Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicate code in data-mate #3752

Open
jsnoble opened this issue Sep 13, 2024 · 0 comments
Open

duplicate code in data-mate #3752

jsnoble opened this issue Sep 13, 2024 · 0 comments

Comments

@jsnoble
Copy link
Member

jsnoble commented Sep 13, 2024

data-mate/src/document-matcher/logic-builder/ip.ts and data-mate/src/data-frame/search/ip-utils.ts are nearly the exact same with barely and difference besides some some string validation. Need to investigate why there is a duplicate and the consequences the code changes have made to each other and if there are behaviour differences between the two of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant