Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prom Metrics class within Teraslice needs to discover which url to associate with exported metrics #3748

Open
busma13 opened this issue Sep 11, 2024 · 1 comment
Labels
k8s Applies to Teraslice in kubernetes cluster mode only. question

Comments

@busma13
Copy link
Contributor

busma13 commented Sep 11, 2024

While working on #3743 we have discovered that the url label was missed in the move from the external teraslice-exporter to the one built into terafoundation.

The url where an instance of teraslice lives on the network is controlled at the k8s level (if I understand this correctly), so either needs to be provided as an environmental variable or added as a field to the terafoundation. If added to the terafoundation, do we include prom_metrics in the key? This makes sense with our current use case, but the url could be needed in other contexts in the future that are not prom metrics related.

Another option is to have the dashboard add the url labels to each metric after they are scraped by grabbing the url from the Ingress.

@busma13 busma13 added question k8s Applies to Teraslice in kubernetes cluster mode only. labels Sep 11, 2024
@godber
Copy link
Member

godber commented Sep 19, 2024

This should be fixed in the v2.3.2 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
k8s Applies to Teraslice in kubernetes cluster mode only. question
Projects
None yet
Development

No branches or pull requests

2 participants