Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service-spec tests are weak #3715

Open
busma13 opened this issue Aug 8, 2024 · 0 comments
Open

service-spec tests are weak #3715

busma13 opened this issue Aug 8, 2024 · 0 comments
Labels
pkg/scripts tests

Comments

@busma13
Copy link
Contributor

busma13 commented Aug 8, 2024

The tests in service-spec only ensure that an error is thrown and surfaced. They do not actually test that loadOrPullServiceImages or ensureServices work properly. Testing these would require standing up docker images or mocking the docker execa commands. It may not be worth the effort, but we should consider it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pkg/scripts tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@busma13