Fix: race condition between WriteStream close and process exit

[andrewjanssen]

The process may exit before the WriteStream finishes writing to the target file. For example, I have a small release file for which only the first of two stream chunks is downloaded because the process terminates first, resulting in a corrupted file.

Thank you for this useful package!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.60%. Comparing base (b10e911) to head (0a87690).
Report is 9 commits behind head on master.

❗ Current head 0a87690 differs from pull request most recent head 586040b. Consider uploading reports for the commit 586040b to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #281      +/-   ##
==========================================
+ Coverage   74.19%   74.60%   +0.40%     
==========================================
  Files           7        7              
  Lines         124      126       +2     
  Branches       28       29       +1     
==========================================
+ Hits           92       94       +2     
  Misses         32       32              

Files	Coverage Δ
src/download.ts	96.87% <100.00%> (+0.20%)	⬆️

[andrewjanssen]

The Travis build is failing on node v12, I wonder if it's due to these close changes in Node 14. Assuming that's the problem— since node 12 is EOL, let me know if you would like me to request the close event to support node 12, or not.

[godber]

Yeah, we should abandon the old node versions, and I've just noticed this is still on TravisCI ... thanks for the PR, we'll get back to you on this one.

[busma13]

This looks good. Thanks @andrewjanssen
We'll need to merge #284 first

[godber]

@andrewjanssen we've reworked our CI to run in Github and done some package updates, can you update your branch and bump the version in package.json to 0.8.10?

[andrewjanssen]

can you update your branch and bump the version in package.json to 0.8.10?

Done!

[godber]

Looks great! Tests pass, thanks for the contribution @andrewjanssen !

[godber]

fixes: #283