Does not return error in GenerateReplicationTasks when history not found #6469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes temporalio#6468 Signed-off-by: Hardy Ferentschik <[email protected]>
|
|
yux0
approved these changes
Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6468
What changed?
If a history cannot be found while processing a workflow execution batch in
GenerateReplicationTasksa warning is logged, but the not found error is not returned to allow the batch to continueWhy?
See #6468
How did you test it?
Ran existing unit tests
Potential risks
Minimal.
Documentation
n/a
Is hotfix candidate?