Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new kb article numerictextbox-disable-arrows #2398

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Added new kb article numerictextbox-disable-arrows #2398

merged 2 commits into from
Oct 4, 2024

Conversation

kendo-bot
Copy link
Collaborator

No description provided.

@kendo-bot kendo-bot requested a review from a team as a code owner September 29, 2024 20:40
@xristianstefanov xristianstefanov self-assigned this Sep 29, 2024
@xristianstefanov xristianstefanov added the merge-to-production Use this label to get a comment to choose whether to merge the PR to production label Sep 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

Hello @xristianstefanov,

Check the below option if you would like to automatically generate PR to production. The automation uses the branch for the cherry-pick, and then will delete the branch. Please, do not delete it manually.

  • create PR to production

@xristianstefanov xristianstefanov requested a review from a team September 29, 2024 20:41
ikoevska
ikoevska approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@ikoevska ikoevska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving from the perspective of the technical writing team. It seems there are other outstanding issues. Please, don't merge before resolving them as needed.

Consider re-requesting a review after addressing Dimo's comments.

knowledge-base/numerictextbox-disable-arrows.md Outdated Show resolved Hide resolved
knowledge-base/numerictextbox-disable-arrows.md Outdated Show resolved Hide resolved
@xristianstefanov xristianstefanov merged commit 79c5b3f into master Oct 4, 2024
1 check passed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024

Here you are the link to your PR to production: 2411

@github-actions github-actions bot mentioned this pull request Oct 4, 2024
Merged
@github-actions github-actions bot deleted the new-kb-numerictextbox-disable-arrows-9fc77cf6080f4a6abf55919ff3b8b295 branch October 4, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimodi dimodi dimodi left review comments

@ikoevska ikoevska ikoevska approved these changes

Assignees

@xristianstefanov xristianstefanov

Labels
merge-to-production Use this label to get a comment to choose whether to merge the PR to production
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kendo-bot @dimodi @ikoevska @xristianstefanov