Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ravamp KB article for Checkbox icon change #2336

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

Tsvetomir-Hr
Copy link
Contributor

@Tsvetomir-Hr Tsvetomir-Hr added the merge-to-production Use this label to get a comment to choose whether to merge the PR to production label Aug 9, 2024
@Tsvetomir-Hr Tsvetomir-Hr requested a review from a team August 9, 2024 13:08
@Tsvetomir-Hr Tsvetomir-Hr self-assigned this Aug 9, 2024
@Tsvetomir-Hr Tsvetomir-Hr requested a review from a team as a code owner August 9, 2024 13:08
Copy link
Contributor

github-actions bot commented Aug 9, 2024

Hello @Tsvetomir-Hr,

Check the below option if you would like to automatically generate PR to production. The automation uses the branch for the cherry-pick, and then will delete the branch. Please, do not delete it manually.

  • create PR to production

knowledge-base/checkbox-custom-icon.md Outdated Show resolved Hide resolved
Copy link
Contributor

@dimodi dimodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Most <link> tag attributes seem unnecessary.
  • Use proper clickable checkbox labels when possible.
  • Place parameters on separate lines when they are more than 2.
  • A CheckBox Value parameter with a name of IndeterminateValue is too hello-world.
  • Consider () => instead of _ =>. Currently we rarely use discards in the docs.
  • Use ThemeConstants instead of hard-coded strings.
  • Use FontAwesome icons that are more different than ours. It's not necessary to have the exact same look.
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/6.6.0/css/all.min.css" />

<p>
    <label>
        <TelerikCheckBox @bind-Value="@CheckBoxValue"
                         Size="@ThemeConstants.CheckBox.Size.Large"
                         Indeterminate="@( !CheckBoxValue.HasValue )"
                         Class="custom-icons" />
        Custom CheckBox
    </label>

    <TelerikButton OnClick="@( () => CheckBoxValue = null )">Make Indeterminate</TelerikButton>
</p>

<style>
    /* Set the Font Awesome family and weight for custom checkbox icons */
    .custom-icons.k-checkbox:before {
        font-family: "Font Awesome 6 Free";
        font-weight: 900;
    }

    /* Remove the default background image for checked state */
    .custom-icons.k-checkbox:checked {
        background-image: none;
    }

        /* Set the Font Awesome check mark icon for the checked state */
        .custom-icons.k-checkbox:checked:before {
            content: "\f058"; /* Check Circle icon */
        }

    /* Remove the default background image for indeterminate state */
    .custom-icons.k-checkbox:indeterminate {
        background-image: none;
    }

        /* Set the Font Awesome question icon for the indeterminate state */
        .custom-icons.k-checkbox:indeterminate:before {
            content: "\3f"; /* Question icon */
            margin-left: 3px;
        }
</style>

@code {
    private bool? CheckBoxValue { get; set; }
}

@Tsvetomir-Hr Tsvetomir-Hr merged commit 99453f7 into master Aug 12, 2024
1 check passed
Copy link
Contributor

Here you are the link to your PR to production: 2339

@github-actions github-actions bot deleted the update-checkbox-icon-change-kb branch August 12, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-to-production Use this label to get a comment to choose whether to merge the PR to production
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants