-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ravamp KB article for Checkbox icon change #2336
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tsvetomir-Hr
added
the
merge-to-production
Use this label to get a comment to choose whether to merge the PR to production
label
Aug 9, 2024
Hello @Tsvetomir-Hr, Check the below option if you would like to automatically generate PR to production. The automation uses the branch for the cherry-pick, and then will delete the branch. Please, do not delete it manually.
|
ikoevska
approved these changes
Aug 9, 2024
dimodi
reviewed
Aug 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Most
<link>
tag attributes seem unnecessary. - Use proper clickable checkbox labels when possible.
- Place parameters on separate lines when they are more than 2.
- A CheckBox Value parameter with a name of
IndeterminateValue
is too hello-world. - Consider
() =>
instead of_ =>
. Currently we rarely use discards in the docs. - Use
ThemeConstants
instead of hard-coded strings. - Use FontAwesome icons that are more different than ours. It's not necessary to have the exact same look.
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/6.6.0/css/all.min.css" />
<p>
<label>
<TelerikCheckBox @bind-Value="@CheckBoxValue"
Size="@ThemeConstants.CheckBox.Size.Large"
Indeterminate="@( !CheckBoxValue.HasValue )"
Class="custom-icons" />
Custom CheckBox
</label>
<TelerikButton OnClick="@( () => CheckBoxValue = null )">Make Indeterminate</TelerikButton>
</p>
<style>
/* Set the Font Awesome family and weight for custom checkbox icons */
.custom-icons.k-checkbox:before {
font-family: "Font Awesome 6 Free";
font-weight: 900;
}
/* Remove the default background image for checked state */
.custom-icons.k-checkbox:checked {
background-image: none;
}
/* Set the Font Awesome check mark icon for the checked state */
.custom-icons.k-checkbox:checked:before {
content: "\f058"; /* Check Circle icon */
}
/* Remove the default background image for indeterminate state */
.custom-icons.k-checkbox:indeterminate {
background-image: none;
}
/* Set the Font Awesome question icon for the indeterminate state */
.custom-icons.k-checkbox:indeterminate:before {
content: "\3f"; /* Question icon */
margin-left: 3px;
}
</style>
@code {
private bool? CheckBoxValue { get; set; }
}
dimodi
approved these changes
Aug 12, 2024
Here you are the link to your PR to production: 2339 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
merge-to-production
Use this label to get a comment to choose whether to merge the PR to production
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: https://github.com/telerik/blazor/issues/9852