Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/amqps protocol #689

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

StWiemann
Copy link

Since we are going to use AMQP in a future project I changed the URI-generation a bit to enable TLS-connections.
It does not yet support client-certificates, since that isn't strictly needed in my use-case but I thought maybe somebody else might be interested in AMQPS.

I did it analogous to mqtts, even though that might confuse some people due to AMQP-Protocols 0.9.1 vs 1.0 being a very different thing. This still uses 0.9.1, nothing changed there.

The new Env would be:
- IOTA_AMQP_PROTOCOL=amqp or amqps

Don't really know if the testing-part works as intended. Basically just c/p'ed from MQTT_PROTOCOL...

@mapedraza
Copy link
Collaborator

Thank you for your contribution @StWiemann

An entry to CHANGES_NEXT_RELEASE file is required before merging.

Could you please open a twin PR on https://github.com/telefonicaid/iotagent-ul repo?

@@ -58,7 +58,7 @@
},
"keywords": [],
"dependencies": {
"amqplib": "~0.5.1",
"amqplib": "~0.10.3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be also mentioned in the CHANGES_NEXT_RELEASE file. Something like this:

- Upgrade amqplib dependency from ~0.5.1 to ~0.10.3

@fgalan
Copy link
Member

fgalan commented May 30, 2023

Thank you for your contribution @StWiemann

An entry to CHANGES_NEXT_RELEASE file is required before merging.

Could you please open a twin PR on https://github.com/telefonicaid/iotagent-ul repo?

@StWiemann did you take into account this feedback provided by @mapedraza , please? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants