Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable skipping pre-commit hook repos during development dependency update workflow and action #158

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

nfelt14
Copy link
Collaborator

@nfelt14 nfelt14 commented Oct 22, 2024

Proposed changes

feat: Add the ability to skip updating a pre-commit repo as a part of the reusable workflows to enable working around hooks that no longer work if they are updated past a certain version

Addresses #156

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have followed the guidelines in the CONTRIBUTING document
  • I have signed the CLA
  • I have checked to ensure there aren't other open Pull Requests for the same update/change
  • I have created (or updated) an Issue to track the status of this update/change and updated the link in this PR description (see above in the Proposed changes section) using the wording Addresses #<issue_number>
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • Basic linting passes locally with my changes
  • I have added necessary documentation (if appropriate)
  • I have updated the Changelog with a brief description of my changes

@nfelt14 nfelt14 requested a review from a team as a code owner October 22, 2024 19:35
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (dd3798a) to head (019f8d2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #158   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          211       224   +13     
  Branches        26        30    +4     
=========================================
+ Hits           211       224   +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nfelt14 nfelt14 force-pushed the nfelt14/enable-skipping-updating-pre-commit-hooks branch 3 times, most recently from 49a19b1 to 8c4fc75 Compare October 22, 2024 20:39
… the reusable workflows to enable working around hooks that no longer work if they are updated past a certain version
@nfelt14 nfelt14 force-pushed the nfelt14/enable-skipping-updating-pre-commit-hooks branch from 8c4fc75 to 019f8d2 Compare October 22, 2024 20:46
Copy link

github-actions bot commented Oct 22, 2024

Test Results (ubuntu)

path passed subtotal
tests/test_bump_version_in_files.py 5 5
tests/test_create_unique_testpypi_version.py 7 7
tests/test_find_unreleased_changelog_items.py 6 6
tests/test_update_development_dependencies.py 13 13
TOTAL 31 31

Link to workflow run

Copy link

github-actions bot commented Oct 22, 2024

Test Results (windows)

path passed subtotal
tests\test_bump_version_in_files.py 5 5
tests\test_create_unique_testpypi_version.py 7 7
tests\test_find_unreleased_changelog_items.py 6 6
tests\test_update_development_dependencies.py 13 13
TOTAL 31 31

Link to workflow run

Copy link

github-actions bot commented Oct 22, 2024

Test Results (macos)

path passed subtotal
tests/test_bump_version_in_files.py 5 5
tests/test_create_unique_testpypi_version.py 7 7
tests/test_find_unreleased_changelog_items.py 6 6
tests/test_update_development_dependencies.py 13 13
TOTAL 31 31

Link to workflow run

@nfelt14 nfelt14 merged commit 5dab1a3 into main Oct 22, 2024
39 checks passed
@nfelt14 nfelt14 deleted the nfelt14/enable-skipping-updating-pre-commit-hooks branch October 22, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant