-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make yq task more accepting of whatever is put in SCRIPT #1095
base: main
Are you sure you want to change the base?
Make yq task more accepting of whatever is put in SCRIPT #1095
Conversation
Catlin Output
|
@frerikandriessen can you please fix the CI? |
Issues go stale after 90d of inactivity. /lifecycle stale Send feedback to tektoncd/plumbing. |
Stale issues rot after 30d of inactivity. /lifecycle rotten Send feedback to tektoncd/plumbing. |
Rotten issues close after 30d of inactivity. /close Send feedback to tektoncd/plumbing. |
@tekton-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/reopen |
@frerikandriessen: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Catlin Output
|
1 similar comment
Catlin Output
|
/retest |
Am I interpreting the results correctly that it failed while testing
Is that even related to my changes? If so, how would I fix it? If not, what now? |
/test pull-tekton-catalog-integration-tests |
@vinamra28 pinging you because I've left this to rot for quite some time. |
@frerikandriessen can you please try to rebase your branch with latest upstream/main and then retry? |
Catlin Output
Catlin script lint Output
|
Catlin Output
Catlin script lint Output
|
@vinamra28 is it good like this or do you want me to rebase the merge-commit? |
@frerikandriessen that would be very helpful 😅 |
Issues go stale after 90d of inactivity. /lifecycle stale Send feedback to tektoncd/plumbing. |
Changes
This make the yq task more accepting of whatever is put in the SCRIPT param.
I currently had some issues with SCRIPT values as
or
both should just work, since they're valid scripts.
This is fixed now (and I've used them both in my pipeline so it seems to actually work)
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
contains
/kind <type>
. Valid types are bug, cleanup, design, documentation,feature, flake, misc, question, tep
File path follows
<kind>/<name>/<version>/name.yaml
Has
README.md
at<kind>/<name>/<version>/README.md
Has mandatory
metadata.labels
-app.kubernetes.io/version
the same as the<version>
of the resourceHas mandatory
metadata.annotations
tekton.dev/pipelines.minVersion
mandatory
spec.description
follows the conventionSee the contribution guide for more details.