Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhenomD and PhenomPv2 discontinuity #13

Open
zipengwang98 opened this issue Jul 12, 2023 · 0 comments
Open

PhenomD and PhenomPv2 discontinuity #13

zipengwang98 opened this issue Jul 12, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@zipengwang98
Copy link
Collaborator

several things I noticed while working on IMRphenomPv2:

  • At the 1e-5~1e-20 matching level, a constant time shift between the waveform matters. in PhenomP they calculate the time shift using 3rd order spline approximation of the waveform around fRD. By reproducing their routine (instead of taking derivatives using autodiff) I increased the matching between ripple and lalsuite from 1e-5 to 1e-10.
  • There is a discrepancy between phenomD and phenomPv2 in lalsuite. This can be seen by matching lal's phenomD and lal's phenomP with no in-plane spins: the matching is bad.
  • There is also a discontinuity in lal's phenomPv2 right at in-plane spin = 0 (not in ripple as far as I know). The waveform with s_x = 0.0001 is different (a constant phase shift maybe?) from that with s_x = 0.
@zipengwang98 zipengwang98 added the bug Something isn't working label Jul 12, 2023
@zipengwang98 zipengwang98 self-assigned this Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant