New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change main functions for PhenomD and PhenomX #11

Open

tedwards2412 opened this issue Jun 1, 2023 · 1 comment

Assignees

Owner

tedwards2412 commented Jun 1, 2023

Function names should be "gen_Phenom..._hphc"
Function signature should be gen_Phenom..._hphc(f, theta, **kwarg)

The default mode of each waveform should fail if you do not pass in an f_ref argument

tedwards2412 self-assigned this

Owner Author

tedwards2412 commented Jul 20, 2023

#14 makes the initial change i.e. changes PhenomD and PhenomXAS waveform generators to use the hphc function naming rather than polar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment