Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix encoding bug #173

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix encoding bug #173

wants to merge 2 commits into from

Conversation

tomsommer
Copy link
Contributor

in_array() is case-sensitive and $parameters['charset'] is lower-case while mb_list_encodings() is upper-case

@tomsommer
Fix encoding bug
80179f3 
in_array() is case-sensitive and $parameters['charset'] is lower-case while mb_list_encodings() is upper-case
@tomsommer
Copy link
Contributor Author

Fixes #148

@HighOnMikey
Copy link

👍

Although probably might be better to use if (empty(preg_grep('/' . $parameters['charset'] .'/i', mb_list_encodings()))) {}

@shacky
Copy link

shacky commented Jul 21, 2016

thanks for bug resolution! it should be merged.

This was referenced Apr 20, 2017
Open
Open
@deemyboy
Copy link

so has this fix been merged or not?

dmromanov
dmromanov approved these changes Oct 10, 2017
View reviewed changes
Copy link

@dmromanov dmromanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

dmromanov
dmromanov suggested changes Oct 10, 2017
View reviewed changes
Copy link

@dmromanov dmromanov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Output of mb_list_encodings() must be converted to upper-case too, because not all encodings returned are upper-case. For example, "Windows-1251".

dmromanov
dmromanov approved these changes Oct 10, 2017
View reviewed changes
Copy link

@dmromanov dmromanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@nurtext
Copy link

nurtext commented Sep 4, 2018

Will this PR ever be merged & closed?

nurtext pushed a commit to nurtext/Fetch that referenced this pull request Sep 5, 2018
fix: tedious#173
e90abcc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmromanov dmromanov dmromanov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tomsommer @HighOnMikey @shacky @deemyboy @nurtext @dmromanov