Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PEP8 compliance check #16

Merged
merged 7 commits into from
Feb 2, 2024
Merged

Conversation

emileferreira
Copy link
Contributor

This adds a PEP8 compliance check, using pycodestyle, to the GitHub Action workflow. It ignores W191 (indentation contains tabs), and the un-enforced PEP8 warnings and errors.

@emileferreira
Copy link
Contributor Author

I've ignored a few more errors (E101, E128 and E712) and fixed the PEP8 transgressions that have slipped in since I formatted the codebase.

@gailweiss
Copy link
Contributor

what was causing e712 (was it unfixable?)?
otherwise cool, thank you!!

@emileferreira
Copy link
Contributor Author

The comparison on line 74 of Sugar.py. I've implemented a hack to avoid violating E712 and removed E712 from the ignore list.

@gailweiss gailweiss merged commit dbe50c6 into tech-srl:main Feb 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants