Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare MixpanelTrack at app startup #12

Open
zupo opened this issue Aug 24, 2019 · 0 comments
Open

Prepare MixpanelTrack at app startup #12

zupo opened this issue Aug 24, 2019 · 0 comments
Labels
good first issue Good for newcomers

Comments

@zupo
Copy link
Member

zupo commented Aug 24, 2019

Currently, we instantiate MixpanelTrack on every request. The operation is not entirely trivial as there is a bunch of "dotted-name" resolving and checks performed. On every request!

The expensive resolving and checking should be done when app starts up, and then on request.mixpanel call only the distinct_id is set, nothing more.
@zupo zupo added the good first issue Good for newcomers label Aug 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zupo