Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom "Site Maintenance" page #9

Open
Cryptophobia opened this issue Mar 13, 2018 · 3 comments
Open

Custom "Site Maintenance" page #9

Cryptophobia opened this issue Mar 13, 2018 · 3 comments

Comments

@Cryptophobia
Copy link
Member

From @jayjun on June 21, 2017 16:14

It'll be nice to be able to customise the blank "Site Maintenance" page, seen after deis maintenance:on.

Maybe a volume of static files can be mounted for nginx to read from. Not sure which volume type fits best?

Copied from original issue: deis/router#349

@Cryptophobia
Copy link
Member Author

From @krancour on June 26, 2017 18:25

A simpler implementation would be (optional) support for a designated "maintenance app" to which all traffic for an app under maintenance can be routed.

@Cryptophobia
Copy link
Member Author

From @chdsbd on December 13, 2017 19:5

Heroku has a pretty simple solution of using config variables pointing to static page urls: https://devcenter.heroku.com/articles/error-pages#configure-your-application. So a user could set a config variable MAINTENANCE_PAGE_URL pointing to some static site to display.

From a cursory glance through the code base, this will require changes across multiple repos (there are probably more): controller, router model, router nginx config, workflow-cli

EDIT: Just realized Workflow is EOL... ☹️

@Cryptophobia
Copy link
Member Author

This can be done and it would be a nice feature for the hephy-router. It can be done through annotations of a GLOBAL_MAINTENANCE_PAGE_URL on the router deployment object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant