Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element detail modal improvements #11

Closed
2 of 4 tasks
lorenzoPrimi opened this issue Feb 27, 2023 · 4 comments · Fixed by #24
Closed
2 of 4 tasks

Element detail modal improvements #11

lorenzoPrimi opened this issue Feb 27, 2023 · 4 comments · Fixed by #24

Comments

@lorenzoPrimi
Copy link
Contributor

lorenzoPrimi commented Feb 27, 2023

  • Finish adding rows to match Android. For sure Instagram and Pouch, need to verify what else
  • Phone number parsing isn't working for all formats. Can mimic Android repo implementation
  • Hide tags initially. Tags button shows/hides.
  • Change "Verify" button to "Verify or Report" to match android
@salvatoto
Copy link
Collaborator

@lorenzoPrimi

  1. "Finish adding rows to match Android. For sure Instagram and Pouch, need to verify what else"
    ^ This goes along with the missing contact buttons on the Community Detail screen. Just missing contact links here as well

  2. This you fixed

  3. Android has the tags dump hidden initially and you can turn them on in Settings. I just implemented on by default. I do like on by default after implementing better styling. We could implement a settings switch to turn off (would require starting a Settings screen first!)

  4. Still says just "Verify", Android says "Verify or Report"

@lorenzoPrimi
Copy link
Contributor Author

For the 4, it is a quick fix, but you might want to have a look at #6 to keep in sync iOS and android

@lorenzoPrimi
Copy link
Contributor Author

lorenzoPrimi commented Mar 13, 2023

Working on this, I have a question about (1)
Why does the "Verify" button, changes into "Pay" when there is a Pouch link? #21
There is no need to verify anymore?
Is this the right logic?


Moving (3) in a separate issue #23

@salvatoto
Copy link
Collaborator

Why does the "Verify" button, changes into "Pay" when there is a Pouch link? #21

Honestly I don't know. Just saw that on the android app recently. But missed the conversation on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants