Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate shooting #1

Open
AquaMorph opened this issue Apr 16, 2015 · 1 comment
Open

Duplicate shooting #1

AquaMorph opened this issue Apr 16, 2015 · 1 comment

Comments

@AquaMorph
Copy link

If the shooting trigger is hit multiple times the robot will shoot more than one shot back to back. Dangerous at demos with little kids rushing to the robot after it shoots.

@CarlColglazier
Copy link

Sounds like something that needs be fixed.

@stonewareslord @int0x191f2 : Are the shooting and waitingToFire booleans declared at the top of the file doing anything currently? Was that designed to prevent this issue or is it unrelated?

Looking at the code, it seems like hasShot, which is always called using bool shooter_fired(), is being used to check the state of the shooter; however, when bool shooter_fire() (which is only ever used once) is called, the tree that seems to actually shoots does not seem to declare that it is shooting.

Apparently, master was made obsolete at some point. I shall take a look at the current branch later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants