-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add number format 55 (Kor FMT, yyyy/mm/dd) #811
Comments
Stale issue message |
I'm pretty sure it was just an oversight. Adding it shouldn't be a hassle. |
@9ssi7 since you have identified the issue and this has triaged, would you help with a PR maybe? |
@tealeg @9ssi7 I looked around and found that more default number formats (including format no 55 discussed here) are language specific in exceljs, although number format 55 for What do you think of language-specific number format? Seems convoluted to me 😖 |
@benedictjohannes I think that would require some work to implement correctly. I've considered for a while that it might be a mistake to have the library set up things like this. In some theoretical rewrite it would be simpler to force all interactions to start from an existing document and have these predefined things just be provided. |
When I tried to format dates today, I saw that it was only formatted in dd-mm-yy format. After doing some research, I realized that Microsoft had support for this
See Office Standarts
, but it was omitted in this package.the area that will contain the change in question: https://github.com/tealeg/xlsx/blob/master/xmlStyle.go#L59
Is there a particular reason why it wasn't added?
The text was updated successfully, but these errors were encountered: