Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give us some more information on grouped media #643

Open
xwisdomowl opened this issue Sep 30, 2024 · 1 comment
Open

Give us some more information on grouped media #643

xwisdomowl opened this issue Sep 30, 2024 · 1 comment

Comments

@xwisdomowl
Copy link

Right now the media groups are simply different Message updates grouped together by a unique media_group_id. This implementation lacks a major thing that it gives no context about how many updates are left to receive.

According to PTB the best way is to start a timer, and listen the messages only received in the time frame. Which is pure garbage. (I'm sorry to say this tho). The other way is to make the user send a "finished" interaction, which is also kind of dumb in many situations. For example, let's say my bot is waiting for 3 photo messages. User sends 5, my code might invoke photo handlers redundantly, giving users negative experience.

So, I'd say if we can have a media_group_item_count or something like that, to actually determine the total number of items in the media group, that'd be amazing. With this we can actually expect this many number of items.

Thanks!

@levlam
Copy link
Contributor

levlam commented Sep 30, 2024

This implementation lacks a major thing that it gives no context about how many updates are left to receive.

It is theoretically impossible to know this and it is theoretically impossible to have media_group_item_count.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants