Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge Browser Compatible #10

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

arasouli91
Copy link

A few minor changes to make it compatible with Edge.

Not sure why this was breaking compatibility with Edge, spread syntax is supposed to be supported by Edge.
I believe the issue is crypto is a member of Window, so it is not accessible in a worker.
@tbfleming
Copy link
Owner

I thought I saw somewhere that Edge finally supports spread. If it still doesn't, then Microsoft reverted back to its old ways and is letting Edge rot.

@arasouli91
Copy link
Author

CanIuse.com says spread is supported by all Edge versions. So, I am not sure why it was causing problems, and at one point the error said imports.env is not an iterable. Not sure why the error was inconsistent either, but it mostly said expected a string or an identifier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants