Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChainKey is not saved at the end of Frost keygen #114

Open
lucky1024 opened this issue Dec 31, 2023 · 0 comments
Open

ChainKey is not saved at the end of Frost keygen #114

lucky1024 opened this issue Dec 31, 2023 · 0 comments

Comments

@lucky1024
Copy link

ChainKey is not saved at the end of Frost keygen:

func (r *round3) Finalize(chan<- *round.Message) (round.Session, error) {
	ChainKey := types.EmptyRID()
	for _, j := range r.PartyIDs() {
		ChainKey.XOR(r.ChainKeys[j])
	}

The variable ChainKey is never used later.

https://github.com/taurusgroup/multi-party-sig/blob/4d84aafb57b437da1b933db9a265fb7ce4e7c138/protocols/frost/keygen/round3.go#L99C1-L103C3

The expected result: save ChainKey into TaprootConfig/Config.

lucky1024 added a commit to lucky1024/multi-party-sig that referenced this issue Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant