Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sidebar to Ember example #2255

Closed
flashdesignory opened this issue Jul 1, 2024 · 8 comments · Fixed by #2261
Closed

Add sidebar to Ember example #2255

flashdesignory opened this issue Jul 1, 2024 · 8 comments · Fixed by #2261

Comments

@flashdesignory
Copy link
Collaborator

Some newer examples did have a missing sidebar, which most of them were added back in this pr: #2254

Could we bring back the sidebar for the Ember example as well?

https://todomvc.com/examples/emberjs/todomvc/dist/

@NullVoxPopuli - is this something that you might be interested in adding? 😄

@NullVoxPopuli
Copy link
Contributor

what's the sidebar look like? does it have markup requirements?

@flashdesignory
Copy link
Collaborator Author

An example can be found here: https://todomvc.com/examples/knockoutjs/

It's part of the todomvc.com website and just gets injected in your build.
It just shows up if you run the todomvc.com website locally, and won't affect the todomvc build.

couple steps needed:

  1. npm install todomvc-common
  2. inject the css somewhere:
  3. inject the js file somewhere: <script src="node_modules/todomvc-common/base.js"></script>
  4. update this file as needed: https://github.com/tastejs/todomvc/blob/master/learn.json

To preview, you'd need to run the todomvc website from the root.

That's pretty much it. Happy to help / review prs.
This would be super helpful 😄

@SparshMadaan
Copy link

Hi flashdesignory,this issue is still open . I'm happy to contibute if this still open .

@flashdesignory
Copy link
Collaborator Author

I'll refer to @NullVoxPopuli, if offloading is desired 😄

@NullVoxPopuli
Copy link
Contributor

oh sorry, yes I keep forgetting about this work -- @SparshMadaan if you want to PR -- I'm more than happy to review!

@SparshMadaan
Copy link

SparshMadaan commented Oct 4, 2024

@NullVoxPopuli I'm beginner in open source and I do some little development project of react js can you please let me know how to run this code in my local machine beacause npm start is not working because I made the changes but not able to see . how can i test this code . just give me an idea please

@NullVoxPopuli
Copy link
Contributor

NullVoxPopuli commented Oct 4, 2024

Do you have errors anywhere?

Might be better to hop in to the ember discord https://discord.gg/emberjs

@SparshMadaan
Copy link

@NullVoxPopuli Thanks Buddy !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants