-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sidebar to Ember example #2255
Comments
what's the sidebar look like? does it have markup requirements? |
An example can be found here: https://todomvc.com/examples/knockoutjs/ It's part of the todomvc.com website and just gets injected in your build. couple steps needed:
To preview, you'd need to run the todomvc website from the root. That's pretty much it. Happy to help / review prs. |
Hi flashdesignory,this issue is still open . I'm happy to contibute if this still open . |
I'll refer to @NullVoxPopuli, if offloading is desired 😄 |
oh sorry, yes I keep forgetting about this work -- @SparshMadaan if you want to PR -- I'm more than happy to review! |
@NullVoxPopuli I'm beginner in open source and I do some little development project of react js can you please let me know how to run this code in my local machine beacause npm start is not working because I made the changes but not able to see . how can i test this code . just give me an idea please |
Do you have errors anywhere? Might be better to hop in to the ember discord https://discord.gg/emberjs |
@NullVoxPopuli Thanks Buddy ! |
Some newer examples did have a missing sidebar, which most of them were added back in this pr: #2254
Could we bring back the sidebar for the Ember example as well?
https://todomvc.com/examples/emberjs/todomvc/dist/
@NullVoxPopuli - is this something that you might be interested in adding? 😄
The text was updated successfully, but these errors were encountered: