-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies and refactor #16
Comments
Maybe worth exploring this? |
As it turns out, I've been re-reading the source to https://next-movie.transitivebullsh.it/ this weekend and fully agree that a refactor that accounts for the points you listed would make sense. My ideal for this implementation would be using Next.js 13 with AppDir. I see that while the OG implem you linked to is using AppDir, the author appears to be considering reverting back to pages: transitive-bullshit/next-movie#1. @leerob if we ignore the theming issue, do you have insight into whether I should wait for vercel/next.js#43159 to be addressed? We can of course just opt for a pages implementation in the refactor, but would be great to actually use AppDir. |
I've gone ahead and made sure we are at least linking to the above implementation as part of the community alternatives section in the TasteJS Movies header over on the main site: https://tastejs.com/movies/ @ transitive-bullshit fyi. I really do like the implementation you wrote up btw. The choices of navigation modes was cool and I also thought it was an interesting idea to support GitHub (vs TMDB) auth for the wishlist. |
A few things to note:
app
directoryreact-*
packages added, which are increasing client JS, in comparison to other framework examples which aren't doing thisThe text was updated successfully, but these errors were encountered: