Avoids false sharing between _top and _bottom #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_top
and_bottom
can see their values modified by multiple threads at the same time, leading to false sharing. This can be avoided at the cost of a larger memory footprint by aligning them to the cacheline.Note that even though
std::hardware_destructive_interference_size
is C++17, not all compilers implement it, so I added a preprocessor check and fallback on the common 64 cacheline size if not present.