Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow artifact-reference to support non-public artifacts #238

Closed
wants to merge 1 commit into from
Closed

Allow artifact-reference to support non-public artifacts #238

wants to merge 1 commit into from

Conversation

willdurand
Copy link

Fixes #90

(assuming I got it right that we don't need more than that...)

jcristau
jcristau reviewed May 10, 2023
View reviewed changes
Copy link
Contributor

@jcristau jcristau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the comments in https://phabricator.services.mozilla.com/D14812 I'm not sure this is right.

@jcristau
Copy link
Contributor

@willdurand taking another look at this, we might be able to change get_artifact_url to not use a bewit URL, and download through the taskcluster proxy directly, since the comment there points at https://bugzilla.mozilla.org/show_bug.cgi?id=1405889 as the reason for doing that dance, and that was resolved years ago.

@jcristau
Copy link
Contributor

The other thing is that resolve_task_references calls get_artifact_url without enabling the proxy, which would need to change for private artifacts.

jcristau
jcristau requested changes May 23, 2023
View reviewed changes
Copy link
Contributor

@jcristau jcristau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving this out of review queue, see previous comments.

@petemoore
Copy link
Member

Related: #407

@ahal ahal self-assigned this Apr 4, 2024
@ahal
Copy link
Collaborator

ahal commented Apr 4, 2024 •
edited
Loading

I ran into this limitation myself, going to take a poke at fixing it.

(Edit: removed erroneous statement)

@ahal
Copy link
Collaborator

ahal commented Apr 4, 2024

Subsumed by #485

@ahal ahal closed this Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcristau jcristau jcristau requested changes

Assignees

@ahal ahal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

artifact-reference should support non-public artifacts
4 participants
@willdurand @jcristau @petemoore @ahal