Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taskgraph build-image fails for images that use $DOCKER_IMAGE_PARENT #582

Open
ahal opened this issue Sep 26, 2024 · 0 comments
Open

taskgraph build-image fails for images that use $DOCKER_IMAGE_PARENT #582

ahal opened this issue Sep 26, 2024 · 0 comments

Comments

@ahal
Copy link
Collaborator

ahal commented Sep 26, 2024

The root issue here is that the build-image tasks and taskgraph build-image, build images two separate ways. The former uses the image_builder image (which is defined in Gecko and imo should live in this repo.. but that's another story). This image_builder image uses kaniko and a bit of custom Rust code, and is where the $DOCKER_IMAGE_PARENT variable is processed. The latter simply shells out to docker build. So obviously, that's not going to recognize our custom parent syntax.

Instead, taskgraph build-image should also use the image_builder image and try to replicate what the build-image tasks do as much as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant