Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup OpenSSF scorecards and fix issues #530

Open
larseggert opened this issue Jul 1, 2024 · 6 comments
Open

Setup OpenSSF scorecards and fix issues #530

larseggert opened this issue Jul 1, 2024 · 6 comments

Comments

@larseggert
Copy link

Pulling in Taskcluster via mozilla/neqo#1935 made neqo's OSSF score drop because of unpatched vulnerabilities in taskcluster:

Reason
7 existing vulnerabilities detected
Details
Warn: Project is vulnerable to: GHSA-jjg7-2v4v-x38h
Warn: Project is vulnerable to: GHSA-h5c8-rqwp-cp95
Warn: Project is vulnerable to: GHSA-h75v-3vvj-5mfj
Warn: Project is vulnerable to: GHSA-9wx4-h78v-vm56
Warn: Project is vulnerable to: GHSA-34jh-p97f-mpxf
Warn: Project is vulnerable to: GHSA-g4mx-q9vg-27p4 / PYSEC-2023-212
Warn: Project is vulnerable to: GHSA-v845-jxx5-vc9f / PYSEC-2023-192

@jcristau
Copy link
Contributor

jcristau commented Jul 1, 2024

These are not vulnerabilities in taskcluster. The report is also older than #1935 getting merged, as far as I can tell.

@jcristau jcristau closed this as completed Jul 1, 2024
@larseggert
Copy link
Author

Yeah, no. The file .taskcluster/requirements.txt was created by taskgraph init; we made no modifications.

@jcristau
Copy link
Contributor

jcristau commented Jul 1, 2024

mozilla/neqo#1935 deletes that file...

@larseggert
Copy link
Author

You're right. The OSSF score was taken when that file was still present. Still, it was created by taskgraph init and had issues.

@ahal
Copy link
Collaborator

ahal commented Jul 1, 2024

I think Julien meant that this repo is not theTaskcluster repo, and any vulnerabilities here do not represent vulnerabilities in the CI system itself.

The scope of this repo is more or less limited to the decision task. That said I've been meaning to setup openssf here already and I don't see why we wouldn't want to fix these.

Also fwiw openssf was a requirement in the recent fxci-config rra I did, so seems prudent to get it going in general

@ahal ahal reopened this Jul 1, 2024
@ahal ahal changed the title Unfixed vulnerabilities Setup OpenSSF scorecards and fix issues Jul 1, 2024
@ahal
Copy link
Collaborator

ahal commented Jul 1, 2024

I think there's some investigation required too. I think last time I looked openssf didn't know about pip-compile-multi, so thought our dependencies weren't locked and gave us a bogus score. This might block on switching to poetry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants