Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remaining type checking errors #476

Open
ahal opened this issue Mar 21, 2024 · 1 comment
Open

Fix remaining type checking errors #476

ahal opened this issue Mar 21, 2024 · 1 comment
Labels
CI Issues affecting Taskgraph's own CI good first issue Good for newcomers

Comments

@ahal
Copy link
Collaborator

ahal commented Mar 21, 2024

#475 refactored our Pyright type checking excludes to be per line rather than ignoring entire files. Fixing these remaining errors is a good first issue!

First ensure you can run pyright locally:

$ pip install -r requirements/dev.txt
$ pyright

You should see no errors. Next:

  1. Search for the string # type: ignore in the code base.
  2. Remove it.
  3. Run pyright and verify you see the error.
  4. Figure out how to fix the error.
  5. Submit a PR

Feel free to batch many fixes into one PR if you like. And no need to fix everything! This issue can be tackled a little bit at a time, possibly even by multiple contributors.

@ahal ahal added good first issue Good for newcomers CI Issues affecting Taskgraph's own CI labels Mar 21, 2024
@ahal
Copy link
Collaborator Author

ahal commented Jun 12, 2024

The change to switch to ignoring type errors line by line finally landed:
ae78c11

So the instructions in this issue make sense now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Issues affecting Taskgraph's own CI good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant