Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n problem] - Russian localization #589

Open
vosska opened this issue Aug 30, 2024 · 4 comments
Open

[i18n problem] - Russian localization #589

vosska opened this issue Aug 30, 2024 · 4 comments
Labels
fixed (hopefully) i18n Localization issue (poor text translation, etc)

Comments

@vosska
Copy link

vosska commented Aug 30, 2024

Greetings to all!

tannerhelland,

localisation has been done exactly according to your instructions.
From the last MASTER.xml (2024.8.40) inserted the translation into in the localization file.
Russian.zip


tannerhelland :

"You are correct that PhotoDemon upgrades do not automatically merge new text into a user's language files.
There is a large risk of accidentally breaking something if the language file has any problems
(for example, not closing an XML tag could lead to large parts of the file getting deleted)."

Checking files .xml in the Cent Browser and editing in Notepad++ :
Asking Sam Spade for help.., Summoning M. C. Escher.., ;)

langversion 2024.8.40

Japanese.xml :

  1. This page contains the following errors:
    error on line 12104 at column 74: xmlParseEntityRef: no name
    Below is a rendering of the page up to the first error.

  2. This page contains the following errors:
    error on line 12164 at column 25: xmlParseEntityRef: no name
    Below is a rendering of the page up to the first error.


French.xml:

  1. This page contains the following errors:
    error on line 14316 at column 10: Opening and ending tag mismatch: translation line 13981 and pdData
    Below is a rendering of the page up to the first error.

  2. This page contains the following errors:
    error on line 14316 at column 11: Opening and ending tag mismatch: phrase line 13979 and pdData
    Below is a rendering of the page up to the first error.


Polish.xml

  1. This page contains the following errors:
    error on line 11288 at column 10: Opening and ending tag mismatch: translation line 11287 and phrase
    Below is a rendering of the page up to the first error.

Thanks for the Photo Demon program!
Good luck!

 With respect, 
       Vladimir
@vosska vosska added i18n Localization issue (poor text translation, etc) unconfirmed labels Aug 30, 2024
@tannerhelland
Copy link
Owner

Thank you so much for this generous contribution, @vosska ! I am excited to add your translation file to PhotoDemon. (It should now be available in nightly builds.)

I am happy to add your name to PhotoDemon's contributor list. Just let me know what name (and URL, if any) you would like me to use.

Thank you again!

(I will also investigate the language files you flagged. PhotoDemon's language file parser does allow some invalid XML syntax to simplify life for translators - for example, the ">" and "<" characters can be used directly instead of being escaped, so that might fail in a browser but work OK in PhotoDemon. I'll double-check everything just to be sure. Thank you for studying those files and letting me know what you found!)

@tannerhelland tannerhelland added the fixed (hopefully) label Aug 31, 2024
@tannerhelland tannerhelland reopened this Aug 31, 2024
@vosska
Copy link
Author

vosska commented Aug 31, 2024

You're welcome! Glad to help!

URL absent.
On the forums I am known as "воська".
Learned about PhotoDemon on - "rsload.net/soft/graphics/18086-photodemon.html"
Also publish translations here.

Thanks again for the program!
Good luck in your creative work!
With respect,
Vladimir

P.S. ( language files - Japanese.xml,French.xml,Polish.xml)

  1. 12104, 74: delete - "&"
  2. 12164, 25: delete - "&"

  1. 13981: Missing closing translation "/translation"

  2. 13979: Missing closing phrase "/phrase"


  1. 11287: Missing closing translation "/translation"

@mid-ff-play17
Copy link

Greetings to all!

tannerhelland,

localisation has been done exactly according to your instructions. From the last MASTER.xml (2024.8.40) inserted the translation into in the localization file. Russian.zip

tannerhelland :

"You are correct that PhotoDemon upgrades do not automatically merge new text into a user's language files. There is a large risk of accidentally breaking something if the language file has any problems (for example, not closing an XML tag could lead to large parts of the file getting deleted)."

Checking files .xml in the Cent Browser and editing in Notepad++ : Asking Sam Spade for help.., Summoning M. C. Escher.., ;)

langversion 2024.8.40

Japanese.xml :

  1. This page contains the following errors:
    error on line 12104 at column 74: xmlParseEntityRef: no name
    Below is a rendering of the page up to the first error.
  2. This page contains the following errors:
    error on line 12164 at column 25: xmlParseEntityRef: no name
    Below is a rendering of the page up to the first error.

French.xml:

  1. This page contains the following errors:
    error on line 14316 at column 10: Opening and ending tag mismatch: translation line 13981 and pdData
    Below is a rendering of the page up to the first error.
  2. This page contains the following errors:
    error on line 14316 at column 11: Opening and ending tag mismatch: phrase line 13979 and pdData
    Below is a rendering of the page up to the first error.

Polish.xml

  1. This page contains the following errors:
    error on line 11288 at column 10: Opening and ending tag mismatch: translation line 11287 and phrase
    Below is a rendering of the page up to the first error.

Thanks for the Photo Demon program! Good luck!

 With respect, 
       Vladimir

Большое спасибо, Владимир!

@mid-ff-play17
Copy link

mid-ff-play17 commented Oct 10, 2024

Thank you so much for this generous contribution, @vosska ! I am excited to add your translation file to PhotoDemon. (It should now be available in nightly builds.)

I am happy to add your name to PhotoDemon's contributor list. Just let me know what name (and URL, if any) you would like me to use.

Thank you again!

(I will also investigate the language files you flagged. PhotoDemon's language file parser does allow some invalid XML syntax to simplify life for translators - for example, the ">" and "<" characters can be used directly instead of being escaped, so that might fail in a browser but work OK in PhotoDemon. I'll double-check everything just to be sure. Thank you for studying those files and letting me know what you found!)

And yes, thank you very much for the program Tanner!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed (hopefully) i18n Localization issue (poor text translation, etc)
Projects
None yet
Development

No branches or pull requests

3 participants